Latest PIVX Core Github Commits

Merge #2968: [CI] Pin CMake version to 3.31.6

02b16429ab80ce1efbf15bdec25d6f420faf6a4b [CI] Pin CMake version to 3.31.6 (Fuzzbawls)

Pull request description:

  GA recently pushed out a silent update to the version of CMake bundled into it's runner images that broke backwards compatibility.

  This pins the version of CMake used in our workflow to maintain backwards compatibility and avoid future silent breaking changes made by GA's bundled cmake version.

ACKs for top commit: 02b16429ab80ce1efbf15bdec25d6f420faf6a4b
  Liquid369:
    ACK 02b16429ab80ce1efbf15bdec25d6f420faf6a4b
  Duddino:
    ACK 02b16429ab80ce1efbf15bdec25d6f420faf6a4b

Tree-SHA512: 268821ef48906564d94dfb26640ac1e88a86e2dd71ae1db34dcd2395b553da98f9ac8ff03e57396a21c5600e10a0f62e9d590ff15f198220e447fd1604c75576

[CI] Pin CMake version to 3.31.6

GA recently pushed out a silent update to the version of CMake bundled into it's runner images that broke backwards compatibility.

This pins the version of CMake used in our workflow to maintain backwards compatibility and avoid future silent breaking changes made by GA's bundled cmake version.

Merge #2966: Make install-params script work when called from other dirs

ab339ae6f2e11ab49579a12ad3df26552bc746b3 Make install-params script work when called from other dirs (Duddino)

Pull request description:

  Adjusts the installl-params.sh script to be able to function from outside the direct path.

ACKs for top commit: ab339ae6f2e11ab49579a12ad3df26552bc746b3
  Fuzzbawls:
    utACK ab339ae6f2e11ab49579a12ad3df26552bc746b3
  Liquid369:
    ACK ab339ae6f2e11ab49579a12ad3df26552bc746b3

Tree-SHA512: e054e54b44d62f985c21cdf980e1241a8ee8ddb676a1b5ae622abe2e05239e6e1b8b882990867c2bbd650b047a37657c35f9a0811dfcb5bef1ad29e70b67b107

Merge #2967: [GA] Bump linux runners to 22.04/24.04

70161c11dfbfdf92861c0a3efe451cf33fdf0595 Build: fix native cctools on ubuntu 22.04+ (Fuzzbawls)
5a2f84d3307267b70f6f8a574d34d2bfcbd63f07 CI: Use Boost 1.74 on Ubuntu 24.04 (Fuzzbawls)
d33549dcea1e48b080f66834aa67f7470e0dc526 Build: remove cdrkit package from depends (Fuzzbawls)
bbf77eda88a69498760db6ce0eaf2de122bc4611 Build: Replace genisoimage with xorriso (Fuzzbawls)
af6ad2c3a585543907eb0d3dfab8fc6874eede5a Build: Run libdmg-hfsplus's DMG tool in make deploy (Fuzzbawls)
544544add204201454a60d801f3884527c1d70c8 Depends: Fix Qt build on GCC 11 (Fuzzbawls)
fe9008534cd13c8399fd2064d0894e77362934bb [Build] Bump CI runner versions for linux (Fuzzbawls)

Pull request description:

  GA will be removing Ubuntu 20.04 runners soon, so this updates the runners we use to accomodate the change.

  Some build/depends system changes were needed to achieve full compatibility, notably:
  - Drop the outdated cdrkit from macOS depends builds and use xorriso instead.
  - Patch Qt's build system to explicetly include <limits> where necessary for gcc 11.
    - https://github.com/bitcoin/bitcoin/pull/20470
  - Pin Boost to 1.74 on Ubuntu 24.04 as there are compile issues with 1.83.

ACKs for top commit: 70161c11dfbfdf92861c0a3efe451cf33fdf0595
  Duddino:
    ACK 70161c11dfbfdf92861c0a3efe451cf33fdf0595
  Liquid369:
    ACK 70161c11dfbfdf92861c0a3efe451cf33fdf0595

Tree-SHA512: 42c14975b436af758c72c7357d451d2edf729dab65ed328271c95c609bd1b1c819b30bfb050478674d6e61decbea421ea69bae4a8d01dc3e71454158d12d6240

Merge #2960: Dash backports2 duddino

33dbf8d8e448fde0633c18777580661d1ae3cf87 Remove unused function (Duddino)
865b8413cbb7a42e8604c6b86fa1038423761f98 [trivial] Fix comment for ForceSetArg() (https://github.com/bitcoin/bitcoin/pull/10479) (laanwj)
399ad8a15ae6e2e8abe42e65a9f3ef6babc9e6bd [Consensus] Add constant for maximum stack size (https://github.com/bitcoin/bitcoin/pull/10313) (Pieter Wuille)
cc040e2c789b0b004b848b6c41e934aa3aafab60 tests: fix spurious addrman test failure (https://github.com/bitcoin/bitcoin/pull/10429) (laanwj)
74a93818972350cf86e0ab0d33e42cb4d1f0d936 Bloomfilter: parameter variables made constant (https://github.com/bitcoin/bitcoin/pull/9750) (Wladimir J. van der Laan)
5f84ea2fe12b49aadb939afe8f166923ea98754c [net] Added SetSocketNoDelay() utility function (https://github.com/bitcoin/bitcoin/pull/10061) (Pieter Wuille)
2770e5a0ce6f683b16a515f8811cbad5cb1f31d5 Output line to debug.log when IsInitialBlockDownload latches to false (https://github.com/bitcoin/bitcoin/pull/10388) (laanwj)
9026e67f4d877a641310d5676e28fbb4622f3e4d tests: Correct testcase in script_tests.json for large number OP_EQUAL (https://github.com/bitcoin/bitcoin/pull/10405) (Wladimir J. van der Laan)
3819bbd0e9cadbfcbbfd2a7ec4a53ecb81f0b6de Add a Log for when nodestates are cleared for peers (laanwj)

Pull request description:

  Cherry-pick of bitcoin backports, following the order of https://github.com/dashpay/dash/pull/2992.
  Some commits had already been backported, as such they have been skipped. Refer to the linked bitcoin PR for more information on each commit

ACKs for top commit: 33dbf8d8e448fde0633c18777580661d1ae3cf87
  Parad0x963:
    utACK 33dbf8d8e448fde0633c18777580661d1ae3cf87
  Liquid369:
    utACK 33dbf8d8e448fde0633c18777580661d1ae3cf87
  Fuzzbawls:
    utACK 33dbf8d8e448fde0633c18777580661d1ae3cf87

Tree-SHA512: 274a206618f8257c672f73dad7f16741ef0e86e99320a4cb96a9b63a3e157e98a0f8eaede45c26cc35309be4438d4e9a28fd526144b11e023bb2fdf81423987d

Merge #2965: [CMake] Add WSL2 support

e2c3f40a1347d12d4558263bf157474174bfb2dd [CMake] Add WSL2 support (Fuzzbawls)

Pull request description:

  Adds WSL2 detection support to CMake builds. WSL2 comes with WSLg by default, allowing users to run linux GUI applications (X11/Wayland) natively without needing a separate XWindow server.

  More Information about WSLg can be found at https://github.com/microsoft/wslg

ACKs for top commit: e2c3f40a1347d12d4558263bf157474174bfb2dd
  Duddino:
    utACK e2c3f40a1347d12d4558263bf157474174bfb2dd
  Liquid369:
    ACK e2c3f40a1347d12d4558263bf157474174bfb2dd

Tree-SHA512: 8df4e2ebf9b0801bf19c8af532fd8398eb6653c5401aaa229442f2711d1210170eda9a670db54a3f7b3eb7d7f0e9e52cb2342ecc33b787ce4315408d8257fa3f

Build: fix native cctools on ubuntu 22.04+

CI: Use Boost 1.74 on Ubuntu 24.04

Build: remove cdrkit package from depends

Build: Replace genisoimage with xorriso

xorriso and its mkisofs/genisoimage emulation alter-ego xorrisofs are
more maintained, and has the right toggles for us to achieve output
determinism without using blunt tools like faketime.

In this commit, we use xorrisofs from the build environment rather than
building it ourselves using depends. This is not necessary and can be
changed in the future.